openrewrite / openrewrite/rewrite
`XML.DocTypeDecl.internalSubsets` are improperly specified as `XML.DocTypeDecl.externalSubsets`
Open
Nobody has claimed this yet.
bug
xml
- Dominant language
- Java
- Stars
- 3.7k
- Forks
- 571
- Avg merge
- 13h 12m
- Merged PRs (30d)
- 261
Description
https://www.tutorialspoint.com/xml/xml_dtds.htm
If you parse the examples from the above link, the internalSubsets are not populated and are always null.
It's unclear what XML document would actually populate the internalSubsets field, as there are no tests that cover it's usage
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by parsing the XML DTD examples from the linked tutorial and inspect how XML.DocTypeDecl populates internalSubsets and externalSubsets. Add focused coverage for the relevant documents, then verify that internalSubsets is populated correctly rather than receiving the external subset value.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100