openrewrite / openrewrite/rewrite
Update MethodMatcher code / comments to be clearer
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 3.7k
- Forks
- 571
- Avg merge
- 13h 12m
- Merged PRs (30d)
- 261
Description
An issue was made in the rewrite-docs repo that the MethodMatcher docs didn't match the code. After some discussions internally, it seems like the code needs to be updated to reflect the docs.
Related issue: https://github.com/openrewrite/rewrite-docs/issues/160
Internal Slack thread: https://moderneinc.slack.com/archives/C01VADFPJQZ/p1681784617833629?thread_ts=1681745099.098229&cid=C01VADFPJQZ
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The payload identifies MethodMatcher and links rewrite-docs issue 160 as context. Start by comparing the MethodMatcher implementation and its comments with that issue's documentation, then review the referenced discussion for the intended behavior. Done means the code and comments agree with the documented behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- devtools
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100