openrewrite / openrewrite/rewrite

ChangeType adds unnecessary import on fully qualified parameterized type.

Open
#2,995 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Java
Stars
3.7k
Forks
570
Avg merge
13h 12m
Merged PRs (30d)
261

Description

    @Test
    void test() {
        rewriteRun(
          java(
            """
            package a;
            public class A1<T> {
            }
            """
          ),
          java(
            """
              public class B {
                  public void method(a.A1<String> a) {
                  }
              }
              """,
            """
              public class B {
                  public void method(a.A2<String> a) {
                  }
              }
              """
          )
        );
    }

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the supplied rewriteRun test for ChangeType with a fully qualified parameterized type. Trace how the transformation handles the type reference and imports. Done means changing a.A1 to a.A2 without adding an unnecessary import.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.