openrewrite / openrewrite/rewrite-static-analysis

Replace nested ifs with one if and conditions joined with &&

Open
#537 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

recipe
Dominant language
Java
Stars
62
Forks
112
Avg merge
1d 19h
Merged PRs (30d)
40

Description

What problem are you trying to solve?

Simplify code.

Describe the situation before applying the recipe

    class A {
        void foo(boolean a, boolean b) {
            if (a) {
                if (b) {
                }
            }
        }
    }

Describe the situation after applying the recipe

    class A {
        void foo(boolean a, boolean b) {
            if (a && b) {
            }
        }
    }

Things to take into account

  • parenthesis might or might not be needed
  • only applicable if there's no other logic in the outer if

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start from the nested-if Java example in the issue and inspect the repository's existing static-analysis recipe conventions. Apply the transformation only when the outer if has no other logic, accounting for whether parentheses are needed. Use the before-and-after examples as recipe tests and verify the nested condition becomes one && condition.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.