openrewrite / openrewrite/rewrite-static-analysis
Improve naming: Change `boolean1` to `bool` and standardize fields
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 62
- Forks
- 112
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 40
Description
The boolean1 name looks kind of off to me because of the text chars and number mix matching.
Is it mandatory because there's the need for numerous fields, so the counting is necessary (which I'm not aware of at the moment)?
I'm assuming not, as the other fields don't have a counter as well.
So I would prefer, suggest, and expect something similar and precise with only alphabetic chars and not numbers - like bool or maybe even boolean_.
https://github.com/quarkusio/quarkus/pull/47303
Source/Reproduce: https://docs.openrewrite.org/recipes/java/migrate/upgradetojava17
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked Quarkus pull request and the OpenRewrite Java 17 migration recipe, since the issue provides no repository file or test path. Trace where the boolean1 and related fields are defined and referenced. Done means the naming is standardized consistently without breaking the recipe or its checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100