openrewrite / openrewrite/rewrite-static-analysis

SimplifyBooleanExpression ignore excessively deep boolean expressions

Open
#387 0 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Java
Stars
62
Forks
112
Avg merge
1d 19h
Merged PRs (30d)
40

Description

This 14000-line class in geotools ends with a ~4000 line boolean condition which begins with ~400 parentheses: https://raw.githubusercontent.com/geotools/geotools/main/modules/unsupported/arcgis-rest/src/main/java/org/geotools/data/arcgisrest/schema/webservice/Attributes.java

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the linked geotools file, Attributes.java, to understand the excessively deep boolean expression described in the issue. Then locate the SimplifyBooleanExpression implementation and its tests; done should mean that this extreme expression is safely ignored without disrupting analysis of ordinary boolean expressions.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.