openrewrite / openrewrite/rewrite-static-analysis
revise Hungarian notation (antipattern)
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 62
- Forks
- 112
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 40
Description
It’s clear why Hungarian notation shouldn’t be used, but this doesn't prevent the actual mess from happening. The issue is that it still occurred. It should be quite simple to match and rename the fields accordingly, as only the prefix needs adjustment. Since the prefix is distinct (e.g., sString), matching based on this with a combination of lower and upper case letters makes it easy to revise. I would appreciate some snippets, and I’ll handle the coding to map all values from the Hungarian notation (an antipattern) and finally push this outdated practice back to the 80s, where it belongs.
References:
SAPUI5 Guidelines
Why Hungarian Notation Should Not Be Used in Modern SAPUI5 Development
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Hungarian-prefixed fields in the rewrite-static-analysis repository and review the linked SAPUI5 guidelines for the intended naming convention. The work is complete when the identified fields are renamed consistently by removing or correcting their prefixes and all affected values are mapped.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100