openrewrite / openrewrite/rewrite-static-analysis
NullableOnMethodReturnType seems incomplete
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 62
- Forks
- 112
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 40
Description
I've just reviewed the new NullableOnMethodReturnType recipe after receiving the latest release locally. To me it seems incomplete:
- It handles Nullable, but not the opposite annotation ("NonNull", "NotNull" or other variants)
- it seems to handle only the rewrite.internal.Nullable annotation, no other Nullable (like checker framework, Eclipse JDT, ...) due to relying on the class reference, not the simple class name literal.
Please be aware I only read the code and didn't run any test. So I might be completely wrong with this analysis.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the NullableOnMethodReturnType recipe mentioned in the issue and verify its current behavior against the reported annotations. Check whether the intended change covers opposite annotations and nullable annotations from frameworks other than rewrite.internal.Nullable; done means the supported scope is explicit and the recipe handles that scope consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100