openrewrite / openrewrite/rewrite-static-analysis
TernaryOperatorsShouldNotBeNested does not handle assignments
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Java
- Stars
- 62
- Forks
- 112
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 40
Description
TernaryOperatorsShouldNotBeNested is only implemented for return statements and lambdas, not assignments (or other possible places for ternaries).
sample
class Test {
public void doThing(String a, String b) {
String result = "a".equals(a) ? "a" : "b".equals(b) ? "b" : "nope";
System.out.println(result);
}
}
expected:
class Test {
public void doThing(String a, String b) {
String result;
if ("a".equals(a)) {
result = "a";
}
else {
result = "b".equals(b) ? "b" : "nope";
}
System.out.println(result);
}
}
actual: no change
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the TernaryOperatorsShouldNotBeNested implementation and reproduce the assignment example from the issue. Extend the existing handling so nested ternaries in assignments produce the shown result, then verify that return statements and lambdas remain covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100