openrewrite / openrewrite/rewrite-migrate-java
Recipe UseTextBlocks: Textblock not constructed AFTER it encounters a variable in a string.
@kunli2 is already working on this.
Since Apr 3, 2023.
- Dominant language
- Java
- Stars
- 156
- Forks
- 130
- Avg merge
- 20h 57m
- Merged PRs (30d)
- 21
Description
Was testing with the UseTextBlocks recipe. Wanted to use it for our SQL statements. Noticed that it works partially. Our SQL statement consists out of + variable or constant + . It appears that after encountering a variable a textblock is no longer created. Also reran mvn rewrite:run again just to see if it would be picked up in a second run. It doesn't. During the test the ONLY active recipe was UseTextBlocks
Question: Is there a minimum number of string concats needed before a textblock is used??
Gonna check all the converted files, should I find more 'interesting things' I can enter it here in this thread.
Before
int thisVariableStopsTextBlocks = 1;
String stringWithVariableInIt =
"This " +
"is " +
"text " +
"BEFORE the variable " +
thisVariableStopsTextBlocks +
"This " +
"is " +
"text " +
"AFTER the variable. " +
"As is visible a TextBlock is no longer constructed";
After org.openrewrite.java.migrate.lang.UseTextBlocks: {convertStringsWithoutNewlines=true}
int thisVariableStopsTextBlocks = 1;
String stringWithVariableInIt =
"""
This \
is \
text \
BEFORE the variable \
""" +
thisVariableStopsTextBlocks +
"This " +
"is " +
"text " +
"AFTER the variable. " +
"As is visible a TextBlock is no longer constructed";
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.