openresty / openresty/openresty-packaging

`make build` does not make sense

Open
#71 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Makefile
Stars
187
Forks
93
PR merge metrics
No merged PRs in 30d

Description

README.md says, "... to build everything from scratch, just run make build".

However, the behavior of make build does not make sense.

The main content of make build:

.PHONY: build
build: zlib-build pcre-build openssl-build \
        openssl-debug-build openresty-build openresty-debug-build \
        openresty-valgrind-build \
        lemplate-build test-nginx-build

However, in almost every sub-build, there is rm -f *.deb, which makes make build end up with only the deb package of the last build as far as outputting deb packages.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with README.md's build instructions and the Makefile's build target, then inspect the sub-build rules containing rm -f *.deb. Confirm how the build target handles packages from each sub-build; done means make build preserves the expected Debian packages from the complete build.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.