Change 97369c4 is probably incorrect
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 1.4k
- Forks
- 252
- Avg merge
- 7d 11h
- Merged PRs (30d)
- 3
Description
I was looking at patches to pull into stock luajit and found the following:
commit 97369c48070d88238dcd45488b296fec693a2dfe (tag: v2.1-20160517)
Author: Yichun Zhang (agentzh)
Date: Tue May 17 14:25:11 2016 -0700removed the GCC 4 requirement for x86 for older systems like Solaris i386.
The change claims to remove the gcc 4.0 minimum requirement check for x86 but the check is in #if LJ_TARGET_X64, which it doesn't look right since it should not be processed for i386.
I could not find a related PR or issue for this, so can you please help me understand this change better? Thanks!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing commit 97369c48070d88238dcd45488b296fec693a2dfe and the LJ_TARGET_X64 conditional it changed. Compare that condition with the commit's stated removal of the GCC 4.0 requirement for x86 and determine whether the behavior is correct for i386 and x86-64. Done means explaining the discrepancy and identifying whether a source change is required.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- build-system, compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100