openresty / openresty/lua-upstream-nginx-module

error: ‘ngx_http_upstream_server_t’ has no member named ‘name’

Open
#58 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
512
Forks
153
Avg merge
1h 29m
Merged PRs (30d)
2

Description

When i compile this module into nginx-1.6.3, it causes an error below:

../lua-upstream-nginx-module/src/ngx_http_lua_upstream_module.c: In function ‘ngx_http_lua_upstream_get_servers’:
../lua-upstream-nginx-module/src/ngx_http_lua_upstream_module.c:179:22: error: ‘ngx_http_upstream_server_t’ has no member named ‘name’
         if (server[i].name.len) {
                      ^
../lua-upstream-nginx-module/src/ngx_http_lua_upstream_module.c:193:22: error: ‘ngx_http_upstream_server_t’ has no member named ‘name’
         if (server[i].name.len) {
                      ^
../lua-upstream-nginx-module/src/ngx_http_lua_upstream_module.c:195:50: error: ‘ngx_http_upstream_server_t’ has no member named ‘name’
             lua_pushlstring(L, (char *) server[i].name.data,
                                                  ^
../lua-upstream-nginx-module/src/ngx_http_lua_upstream_module.c:196:38: error: ‘ngx_http_upstream_server_t’ has no member named ‘name’
                             server[i].name.len);
                                      ^
make[1]: *** [objs/addon/src/ngx_http_lua_upstream_module.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/root/nginx_mon/nginx-1.6.3'
make: *** [build] Error 2

I've tried different versions of this module, it is the same error. nginx-1.6.x should still be supported. @agentzh Could you help me out here ?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/ngx_http_lua_upstream_module.c, especially ngx_http_lua_upstream_get_servers, and compare the referenced ngx_http_upstream_server_t definition in nginx-1.6.3 with the module's expectations. Reproduce the nginx-1.6.3 build and identify a compatibility change that preserves upstream server names; done means the module compiles successfully against that nginx version.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, nginx
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.