openresty / openresty/lua-resty-websocket
When establishing a connection, verify the HTTP1.1 response header
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 523
- Forks
- 112
- Avg merge
- 1d 16m
- Merged PRs (30d)
- 2
Description
I noticed that there are 2 FIXME left in client.lua. Do we have any plans to implement them， I can implement them if necessary.
https://github.com/openresty/lua-resty-websocket/blob/master/lib/resty/websocket/client.lua#L275-L277
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with lib/resty/websocket/client.lua at lines 275-277 and inspect the surrounding connection-establishment flow. Determine what HTTP/1.1 response-header validation the FIXME calls for, then check the project's existing test setup. Done means the required response header is verified during connection establishment and the relevant FIXME is resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100