openresty / openresty/lua-resty-websocket
Not support websocket extensions
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 523
- Forks
- 112
- Avg merge
- 1d 16m
- Merged PRs (30d)
- 2
Description
Hello, when I use this lib for proxy.I found that the project doesn't support websocket extension.
In client.lua,you return error when RSV1, RSV2, RSV3 are not zero.
In server.lua, you doesn't check the Sec-WebSocket-Extensions header.
Maybe the library can be more complete. Is there any plan for this?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading client.lua, where nonzero RSV1, RSV2, or RSV3 currently returns an error, and server.lua, where Sec-WebSocket-Extensions is not checked. Determine the intended extension negotiation and handling scope; done should mean the library supports the requested WebSocket extension behavior without incorrectly rejecting valid frames.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- networking
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100