openresty / openresty/lua-nginx-module

http headers vs unescape_uri bug

Open
#941 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
11.8k
Forks
2.1k
Avg merge
6h 1m
Merged PRs (30d)
6

Description

I am not sure if this is resty bug or nginx bug, but here's how to reproduce it:

  1. Set up nginx as pop3 proxy:
mail {
    auth_http 127.0.0.1:8080/auth;
    pop3_auth         plain;
    ....
  1. Set up 127.0.0.1:8080/auth as a lua generated content:
server {
    listen 127.0.0.1:8080;
    location /auth {
        content_by_lua_block {
            local pass = ngx.unescape_uri(ngx.var.http_auth_pass)
            ngx.log(ngx.ALERT, "Before: ", ngx.var.http_auth_pass, ", after: ", pass)
        }
    }
}
  1. Telnet to your nginx pop3 port and try to provide password like "ca ffe+19" (with space and plus characters)

Here's what you get in error.log:

Before: ca%20ffe+19, after: ca ffe 19

So instead of "ca ffe+19" one would get back "ca ffe 19" where plus char is replaced with space.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the nginx POP3 proxy reproduction and the content_by_lua_block calling ngx.unescape_uri on ngx.var.http_auth_pass. Compare the logged Before/after values for a password containing a space and plus sign to determine whether the behavior belongs to nginx or lua-nginx-module. Done means the source plus remains a plus after unescaping, or the responsible component is clearly identified.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua, nginx
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.