openresty / openresty/lua-nginx-module
Support for client TLS certificate in tcpsock:sslhandshake
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 11.8k
- Forks
- 2.1k
- Avg merge
- 6h 1m
- Merged PRs (30d)
- 6
Description
There's already an option to validate server TLS certificate using lua_ssl_trusted_certificate.
It would be nice if we could provide client TLS certificate, in the same way as ngx_http_proxy module is doing: http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_ssl_certificate, so that there would be two new options:
lua_ssl_certificatelua_ssl_certificate_key
These options would initialise nginx ssl context with client certificates, which would be used during ssl handshake.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the tcpsock:sslhandshake path and trace how lua_ssl_trusted_certificate currently configures the SSL context. Compare that setup with the ngx_http_proxy client-certificate implementation and verify the new certificate and key options are used during the handshake; done means both options work for client TLS authentication and are covered by the relevant tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, nginx
- Domain
- networking, security
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100