openresty / openresty/lua-nginx-module
config: doesn't set flags for Darwin arm64
Open
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 11.8k
- Forks
- 2.1k
- Avg merge
- 6h 1m
- Merged PRs (30d)
- 6
Description
Under MacPorts I ran into the following:
for both nginx 1.22.0 (with static module) and nginx-devel 1.23.0 (with dynamic module) lua-nginx-module-0.10.21 fails to add the flags for arm64 machines. A quick patch
--- config.orig 2022-03-02 00:54:22.000000000 -0600
+++ config 2022-06-23 19:05:00.000000000 -0500
@@ -94,7 +94,7 @@
case "$NGX_PLATFORM" in
Darwin:*)
case "$NGX_MACHINE" in
- amd64 | x86_64 | i386)
+ amd64 | arm64 | x86_64 | i386)
echo "adding extra linking options needed by LuaJIT on $NGX_MACHINE"
luajit_ld_opt="$luajit_ld_opt -pagezero_size 10000 -image_base 100000000"
ngx_feature_libs="$ngx_feature_libs -pagezero_size 10000 -image_base 100000000"
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the config file's Darwin platform branch and inspect how NGX_MACHINE is matched for linker flags. Verify the arm64 case receives the required flags by building or configuring the module on a Darwin arm64 system; done means the flags are added for arm64 without changing existing architectures.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- shell
- Domain
- build-system, operating-systems
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100