openresty / openresty/lua-nginx-module

Yielding in body_filter_by_lua

Open
#2,026 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
11.8k
Forks
2.1k
Avg merge
6h 1m
Merged PRs (30d)
6

Description

I'm curious to know why you didn't provide async facilities in body_filter_by_lua. Is there any hard barrier in Nginx?
I guess it would be possible to suspend a request within a body filter by blocking its read and write event handlers and then deleting timers. Maybe we also need a small patch for ngx_http_finalize_request() to do nothing with that request. Have I missed anything?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the body_filter_by_lua entry point and the Nginx event handlers, timers, and ngx_http_finalize_request() named in the issue. Determine whether suspending a request there is supported and identify the full set of constraints; done means a validated feasibility answer or a clearly scoped implementation plan.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, lua, nginx
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.