openresty / openresty/lua-nginx-module
*_by_lua_block directives break Letsencrypt's certbot
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 11.8k
- Forks
- 2.1k
- Avg merge
- 6h 1m
- Merged PRs (30d)
- 6
Description
This is more of an issue for certbot than for this project but maybe there are some mitigating actions that you could do.
Any directive which includes a lua block like this one breaks certbot's parser and makes the automatic certificate renewal process fail.
location = /ip-address {
default_type text/plain;
content_by_lua_block {
ngx.say(ngx.var.remote_addr)
}
}
There are at least a couple of issues for that on certbot's tracker with he details of what's going on
$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 18.04.4 LTS
Release: 18.04
Codename: bionic
$ dpkg -l "*nginx*"
ii nginx-common 1.14.0-0ubuntu1.9 all small, powerful, scalable web/proxy server - common files
ii nginx-extras 1.14.0-0ubuntu1.9 amd64 nginx web/proxy server (extended version)
ii libnginx-mod-http-lua 1.14.0-0ubuntu1.9 amd64 Lua module for Nginx
...
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the content_by_lua_block directive shown in the issue and compare the linked Certbot reports to confirm the parser failure and its scope. Done would require identifying a concrete mitigation that this module can support or documenting that the failure must be addressed by Certbot.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua, nginx
- Domain
- infrastructure
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100