openresty / openresty/lua-nginx-module

Is there a little bug in function ngx.decode_args?

Open
#1,788 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
11.8k
Forks
2.1k
Avg merge
6h 1m
Merged PRs (30d)
6

Description

Code:
local args = ngx.decode_args("a=hello%world")
for k, v in pairs(args) do
ngx.say("k = ", k, ", v = ", v)
end

Result:
k = a, v = helloworld

I think the result should be:
k = a, v = hello%world

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the ngx.decode_args entry point and reproduce the issue with the provided "a=hello%world" example. Check the existing argument-decoding behavior for this input and add or update coverage for it; done means the returned value preserves the literal percent character as "hello%world".

Written by the indexing model from the issue text.

Assessment

Tech stack
c, lua, nginx
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.