openresty / openresty/lua-nginx-module

Feature request: allow ngx.sleep to be used everywhere

Open
#1,730 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
11.8k
Forks
2.1k
Avg merge
6h 1m
Merged PRs (30d)
6

Description

For those phases without a request, we can implement ngx.sleep as a wrapper of ngx_msleep.
@doujiang24 @rainingmaster
How about this?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the existing ngx.sleep and ngx_msleep implementations and the handling for phases without a request. Determine which phases are currently excluded and how the wrapper should behave there; done means ngx.sleep works in every intended phase without a request.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.