openresty / openresty/lua-nginx-module

Do you consider supporting ssl_protocols and ssl_ciphers dynamically

Open
#1,567 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
11.8k
Forks
2.1k
Avg merge
6h 1m
Merged PRs (30d)
6

Description

in nginx, it can not implement in one port, domain A support tlsv1.2, tlsv1.3 and domain B support tlsv1.2. like it:

http {
    server {
        listen 443 ssl default_server;
        ssl_protocols TLSv1.1 TLSv1.2 TLSv1.3;
        ssl_ciphers "!MD5";
        ssl_ciphers "EECDH+3DES:RSA+3DES:!MD5";
        ...
    }
     server {
        listen 443 ssl;
        server_name  b.com;
        ssl_protocols TLSv1.1 TLSv1.2;
        ssl_ciphers "!MD5";        
        ...
    }
}

OpenSSL 1.1.1+ introduces SSL_CTX_set_client_hello_cb() . Through it can implement control ssl handshake protocols and ciphers by servename. it will be very helpful in some scenarios, such as CDN.

i hope implement it like this

http {
    ssl_client_hello_by_lua_block {
        local ssl = require "ngx.ssl"
	local host = ssl.client_server_name();
	if host == "b.com" then
	    ssl.set_protocols({"TLSv1.1", "TLSv1.2"})
            ssl.set_ciphers("!MD5")
	else
            ssl.set_protocols({"TLSv1.1", "TLSv1.2", "TLSv1.3"})
            ssl.set_ciphers("EECDH+3DES:RSA+3DES:!MD5")
	end
    }
    server {
        listen 443 ssl default_server;
        ssl_protocols TLSv1.1 TLSv1.2 TLSv1.3;
        ssl_ciphers "!MD5";
        ssl_ciphers "EECDH+3DES:RSA+3DES:!MD5";
        ...
    }
}

i try implement it by PR. https://github.com/openresty/lua-nginx-module/pull/1566

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing pull request #1566 and the proposed OpenSSL SSL_CTX_set_client_hello_cb() approach in the issue. Check how SNI-based selection of TLS protocols and ciphers would fit the lua-nginx-module; done means the requested per-server-name behavior is implemented and documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, lua, nginx
Domain
backend, networking, security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.