privileged agent timers not fireing on shutdown

The privileged agents timers that are set to execute later will not execute upon nginx shutdown. ie. prematurely.

The fake watcher with the read->handler set to ngx_http_lua_abort_pending timers, is added although the handler is never executed.

By adding ngx_close_idle_connections within the privileged agents cycle inside the terminate/quit clause I did get the intended result.

I'm not certain that this is the correct solution or if it could have any unexpected consequences.

os/unix/ngx_process_cycle.c:

ngx_privileged_agent_process_cycle(ngx_cycle_t *cycle, void *data)
...

for ( ;; ) {

  if (ngx_terminate || ngx_quit) {
    ngx_log_error(NGX_LOG_NOTICE, cycle->log, 0, "exiting");
+  ngx_close_idle_connections(cycle);
    ngx_worker_process_exit(cycle);
  }
...

Any feedback regarding this, would be appreciated.

Start in os/unix/ngx_process_cycle.c at ngx_privileged_agent_process_cycle and trace how shutdown reaches ngx_worker_process_exit. Compare the privileged agent's timer and fake-watcher lifecycle with the proposed ngx_close_idle_connections call. Done means privileged agent timers execute as intended during nginx shutdown without introducing unexpected connection or process-exit effects.