openresty / openresty/lua-nginx-module

ngx.unescape_uri replace + to space

Open
#1,408 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
11.8k
Forks
2.1k
Avg merge
6h 1m
Merged PRs (30d)
6

Description

Hi There,

I'm using the latest version of Openresty and when unescaping uri several times the + sign is replaced by space.
local c = "http://example.com/over/there?name=foo+bar"
local d = ngx.unescape_uri(c)
print(d)

Output >>> http://example.com/over/there?name=foo bar

Why unescape_uri changes + to space?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the ngx.unescape_uri entry point and reproduce the behavior using the Lua example in the issue. Check the module's URI-unescaping implementation and existing tests, then clarify whether a plus sign should remain unchanged and add coverage for the expected result.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, lua, nginx
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.