openresty / openresty/lua-nginx-module
Be able to set headers with always option set to true
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 11.8k
- Forks
- 2.1k
- Avg merge
- 6h 1m
- Merged PRs (30d)
- 6
Description
Add the ability to use ngx.req.set_header with the always option set to true.
See:
- http://nginx.org/en/docs/http/ngx_http_headers_module.html#add_header
- https://github.com/nginx/nginx/blob/master/src/http/modules/ngx_http_headers_filter_module.c#L858
I haven't found any reference to it. As I know, it would have to be implemented in here: https://github.com/openresty/lua-nginx-module/blob/master/src/ngx_http_lua_headers_in.c#L180
I'd be glad to work this on but I don't really know where to start. I found that the structures where not the same between lua-nginx-module and nginx itself so if someone can help me kicking in, i'm gona take the issue.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading src/ngx_http_lua_headers_in.c around the referenced implementation and compare its header structures with nginx's ngx_http_headers_filter_module.c. Check the related Kong issue for context. Done means ngx.req.set_header supports an always option matching the requested nginx behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, lua, nginx
- Domain
- api, backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100