openresty / openresty/lua-nginx-module
Question about a pending pull request on new API proposal for FFI write
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 11.8k
- Forks
- 2.1k
- Avg merge
- 6h 1m
- Merged PRs (30d)
- 6
Description
Hi,
There is a pending pull request for adding a new output function that performs an FFI write from a given offset and and a give length:
https://github.com/hkmo/lua-nginx-module/pull/2
We are using this new API in our testing and it is working fine, it helps resolve the limitation of not being able to perform ngx.print() for sub-string without making a new copy.
I am wondering what is still needed to merge the pull request to master.
Thanks
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the pending pull request at https://github.com/hkmo/lua-nginx-module/pull/2 and compare its FFI write API with the existing output API described here. The issue names no files or tests; done would require identifying any remaining merge requirements and confirming whether the proposed API is accepted or the pull request should be closed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, lua, nginx
- Domain
- api, backend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 15/100