openresty / openresty/headers-more-nginx-module
error_page disables more_set_headers
Open
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 1.8k
- Forks
- 236
- Avg merge
- 1h 34m
- Merged PRs (30d)
- 2
Description
compare
more_set_headers "name1: value1";
location =/one {
more_set_headers "name2: value2";
return 303 OK;
}
and
location @error {
return 200 OK;
}
more_set_headers "name1: value1";
location =/two {
more_set_headers "name2: value2";
error_page 303 = @error;
return 303 OK;
}
if request one location, it adds two headers name1 with value1 and name2 with value2
but if request two location, it adds only one header name1 with value1
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the two NGINX configurations from the issue and compare the response headers for the direct and error_page flows. Trace how the headers-more module handles headers during error_page processing; done means the second location's header is preserved as in the direct-location case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, nginx
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100