openresty / openresty/headers-more-nginx-module

Add support to ADD to preexistent headers

Open
#102 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
1.8k
Forks
236
Avg merge
1h 34m
Merged PRs (30d)
2

Description

Currently the documentation specifies:

Existing response headers with the same name are always overridden. If you want to add headers incrementally, use the standard add_header directive instead.

But the add_header has the drawback that it removes ALL previously defined add_headers in upper sections.

It could be very useful to add parameters to an already defined header. For example, we can have a global Vary, but need to add more itens just inside a location. Or we may want to expand headers received from a proxy.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named. Start by locating the module's handling of ADD and existing add_header inheritance, then clarify how additions to an inherited Vary header and proxy-provided headers should behave. Done means the intended syntax and behavior are defined and covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, nginx
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.