openresty / openresty/docker-openresty

Request : Add docker-entrypoint.sh provided in the nginx image, so that environment variables can be used in the configuration

Open
#186 4 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

help wanted
Dominant language
Dockerfile
Stars
1k
Forks
536
Avg merge
1d 32m
Merged PRs (30d)
1

Description

It would be nice to add in the image the docker-entrypoint.sh file and the docker-entrypoint.d folder which are provided in the nginx official image and add it as an ENTRYPOINT of the openresty image:

ENTRYPOINT ["/docker-entrypoint.sh"]

(see : https://github.com/nginxinc/docker-nginx/blob/f958fbacada447737319e979db45a1da49123142/mainline/debian/Dockerfile)

This will allow to use environnement variables in the configuration as described here :
https://github.com/docker-library/docs/tree/master/nginx#using-environment-variables-in-nginx-configuration-new-in-119 :)

Note that docker-entrypoint.sh may have to be adapted to support the "/usr/bin/openresty" command:

if [ "$1" = "nginx" -o "$1" = "nginx-debug" ]; then

-->

if [ "$1" = "/usr/bin/openresty"]; then

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the image Dockerfile with the linked nginx Dockerfile, then inspect the provided docker-entrypoint.sh and docker-entrypoint.d components. Done means the openresty image includes them, uses /docker-entrypoint.sh as its entrypoint, and supports the /usr/bin/openresty command and documented environment-variable configuration behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker
Domain
devops, infrastructure
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.