openresty / openresty/docker-openresty

harmonize build flags between build-from-source and upstream-packaged images

Open
#109 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Dockerfile
Stars
1k
Forks
536
Avg merge
1d 32m
Merged PRs (30d)
1

Description

Upstream packaged images (e.g. centos via RPM) have a set of modules and build flags. See https://github.com/openresty/openresty-packaging/blob/master/rpm/SPECS/openresty.spec#L145

Harmonize these flags and make them customizable with build arguments.

For example:

ARG RESTY_LUABIND_XCFLAGS="-DLUAJIT_NUMMODE=2 -DLUAJIT_ENABLE_LUA52COMPAT"

Other things to look at are cc-opt and ld-opt. Related to #108

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the build-from-source image definitions with the upstream RPM spec at the linked line, then review related issue #108. Identify the differing modules, cc-opt, ld-opt, and other build flags; done means the images use harmonized defaults and expose the relevant values as Docker build arguments.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker
Domain
build-system, devops
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.