openradar / openradar/PyDDA

Wrong calculation in weight if more than 2 radars

Open
#142 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Jupyter Notebook
Stars
112
Forks
49
Avg merge
12h 52m
Merged PRs (30d)
2

Description

A syntax problem was found in these parts of _get_dd_wind_field_scipy() and _get_dd_wind_field_tensorflow().

This line "cur_array = parameters.weights[i, k]", cur_array and parameters.weights[i, k] point to the same memory address.
parameters.weights[i, k] has changed when editing cur_array, that will only consider the last result of the loop.

Image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating _get_dd_wind_field_scipy() and _get_dd_wind_field_tensorflow() and inspect how cur_array is assigned and modified inside the radar loop. Verify the behavior with more than two radars, then confirm that each iteration preserves its own weights and that the final wind-field calculation includes every radar result.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, tensorflow
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.