openmultiplayer / openmultiplayer/open.mp
Not quite correct DialogResponse validation for TABLIST_HEADERS style
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 641
- Forks
- 208
- PR merge metrics
- No merged PRs in 30d
Description
Cases when TABLIST_HEADERS dialog is displayed without lines are not taken into account, which creates additional difficulties and breaks the logic of dialog processing on the server (for example, it does not allow you to know if the player has answered the dialog)
Thus, such a dialog will be correctly displayed to the client, but any response to it (including closing) will not be delivered:
ShowPlayerDialog(playerid, 4000, DIALOG_STYLE_TABLIST_HEADERS, "Test", " ", "Ok", "Close");
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the server-side DialogResponse validation for DIALOG_STYLE_TABLIST_HEADERS and reproduce the issue with the ShowPlayerDialog example in the report. Done means responses, including closing the dialog, are delivered when this dialog has no lines.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100