openmultiplayer / openmultiplayer/open.mp

Bug Dialog (last version)

Open
#959 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C++
Stars
641
Forks
208
PR merge metrics
No merged PRs in 30d

Description

The problem with the dialog is that if you send %s %d %i etc to the input(DIALOG_STYLE_INPUT) it will throw an error, the dialog won't show or close, in GetPlayerDialogID(playerid) it will still be considered open

here are the test commands to check
CMD:test(playerid) { //send %s SPD(playerid, 100, DIALOG_STYLE_INPUT, " ", "132", "Send", "cl"); }
CMD:checkdd(playerid) { SCM(playerid, -1, "%d", GetPlayerDialogID(playerid)); }

Release version
[v1.3.1.2739]

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Run the provided CMD:test and CMD:checkdd reproduction against release v1.3.1.2739, using format specifiers such as %s, %d, and %i with DIALOG_STYLE_INPUT. Trace the dialog handling and verify that invalid input does not throw, the dialog remains usable or closes correctly, and GetPlayerDialogID(playerid) no longer reports a stuck dialog.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.