openmultiplayer / openmultiplayer/open.mp

Not server side disconnection player if client exceeded 'messageslimit'

Open
#930 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C++
Stars
641
Forks
208
PR merge metrics
No merged PRs in 30d

Description

If player exceed messages limit for some reason it will reconnect him but only client side. It will say "You are banned from this server." then but he is still in server list remaining spawned on the server. For the fist try to connect back it wont let me in but then after leaving it will finally disconnect me serverside.

Same problem happens with kick for exceeding message hole limit.

Steps to reproduce the behavior:
https://www.youtube.com/watch?v=gsx7cVklBGU

Expected behavior
Just disconnect it like it was timeout.

Release version
omp 1.2.0.2670

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the behavior using the linked video and the reported open.mp 1.2.0.2670 release, testing both the messages-limit and message-hole-limit cases. Done means an affected player is removed server-side like a timeout, rather than remaining in the server list or spawned on the server.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.