openmultiplayer / openmultiplayer/open.mp

non-english nickname

Open
#888 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
641
Forks
208
PR merge metrics
No merged PRs in 30d

Description

When a player enters the game with a non-English nickname, the server will not receive or display any information.

Previously, a Chinese programmer created a plugin for nicknames with Chinese characters. This plugin located the address of the CheckPlayerName function through a characteristic code search and then hooked and managed it. Through this hooking process, the plugin fixed the crash issue caused by the incorrect use of CharLowerA in samp_server.exe.

However, with the updates to the game version, the plugin has become incompatible and can no longer be used. I believe this issue has been a headache for many servers and players, and I hope omp can address and fix this problem.

There are indeed experts who have developed Advanced-SA-NickName (https://github.com/KrYpToDeN/Advanced-SA-NickName), but it is not compatible with omp-server. Furthermore, based on my cursory examination of the code, it seems to be tailored specifically for Cyrillic script.

Thanks for your dedication and efforts.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue identifies CheckPlayerName in samp_server.exe and references the incompatible Advanced-SA-NickName plugin. Start by locating the server's player-name handling entry point and reproducing a non-English nickname; done means the server receives and displays the nickname without the reported failure.

Written by the indexing model from the issue text.

Assessment

Domain
backend, internationalization, localization
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.