openmultiplayer / openmultiplayer/open.mp

rcon password when the default password not changed, the timer will no longer working

Open
#787 0 comments 0 reactions 1 assignee View on GitHub

@Hual is already working on this.

Since Nov 30, 2023.

bug
Dominant language
C++
Stars
641
Forks
208
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
When you downloading the open.mp package and start running it, you'll see that there is an error that tells you to change rcon password, but unlike SA:MP that is closing the program (to indicate something wrong going on), open.mp seem to disable the timer mechanism, making the timer no longer to function normally.

To Reproduce
Steps to reproduce the behavior:

  1. Download open.mp
  2. Make new .pwn inside gamemodes folder, and paste this:
#include <open.mp>

forward OnSomething();
public OnSomething()
{
    print("Will not be called");
}

main()
{
    print("Hello World");
    SetTimer("OnSomething", 1000, false);
}
  1. Compile the script, and run it
  2. See the behaviour

Expected behavior
The legacy plugin, gamemode, filterscript shouldn't be loaded completely if the rcon default password needs to be enforced for users to change it or force close the application like sa-mp does, but i think you can just check if the rcon feature itself is disabled or not to add extra measures to this.

Screenshots and/or logs

Without changing the rcon password:

Loaded 22 component(s) from /home/sui/Documents/pawn-tutorial/components
[2023-11-24T16:31:45+0700] [Error] Your rcon password must be changed from the default password, please change it.
[2023-11-24T16:31:45+0700] [Info] Hallo World

With changed rcon password:

Loaded 22 component(s) from /home/sui/Documents/ysi-tutorial/components
[2023-11-26T09:37:11+0700] [Info] Loading plugin: crashdetect
[2023-11-26T09:37:11+0700] [Info]   CrashDetect plugin 4.21
[2023-11-26T09:37:11+0700] [Info] Hallo World
[2023-11-26T09:37:12+0700] [Info] Will not be called

Release version
Put the release version of the broken build here.
https://github.com/openmultiplayer/open.mp/releases/tag/v1.1.0.2612

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.