openmultiplayer / openmultiplayer/open.mp
Some players with banned IP addresses are able to connect to the server
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 641
- Forks
- 208
- PR merge metrics
- No merged PRs in 30d
Description
Describe the bug
Players with IP addresses that are banned by the server are somehow able to connect to the server.
I am not sure how these players are bypassing the IP ban but I have observed multiple cases where players whose IP addresses are present in the ban list were still able to join the server.
Interestingly, checking the IP address in OnPlayerConnect and manually kicking the player works correctly:
new ip[ 32 ]; GetPlayerIp( playerid, ip, sizeof( ip ));
if (IsBanned(ip))
{
Kick(playerid);
}
When this check is used, the affected players are successfully kicked. This suggests that the IP ban itself is being detected correctly, but the built-in connection/IP ban handling may not be preventing these connections as expected.
Expected behavior
A player connecting from an IP address that is present in the server's IP ban list should be rejected automatically and should not be allowed to enter the server.
Screenshots and/or logs
//
Release version
open.mp server v1.5.8.3079
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with an IP in the server ban list, then trace the built-in connection/IP-ban handling and compare it with the working OnPlayerConnect path using GetPlayerIp, IsBanned, and Kick. Done means a banned address is rejected automatically before entering, while an unbanned player can still connect.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend, networking, security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100