openmultiplayer / openmultiplayer/launcher
HidePlayerDialog after server restart or lost connection
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 203
- Forks
- 97
- PR merge metrics
- No merged PRs in 30d
Description
If the player is viewing a dialog and the server restarts(Not through GMX) or he lost connection, HidePlayerDialog does not work for this player.
My suggestion is that HidePlayerDialog should "force" the closing of any possible dialog, even if it hasn't gone through ShowPlayerDialog.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the HidePlayerDialog and ShowPlayerDialog entry points in the launcher and reproduce the behavior after a server restart or lost connection. Determine how dialogs are tracked when no ShowPlayerDialog call occurred; done means HidePlayerDialog closes any remaining player dialog in both scenarios.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100