openmultiplayer / openmultiplayer/launcher
[bug] ingame browser keeps forcing re-render of JoinServerPrompt while editing settings
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 203
- Forks
- 97
- PR merge metrics
- No merged PRs in 30d
Description
When you are trying to change your nickname in the ingame browser, it keeps firing this effect: https://github.com/openmultiplayer/launcher/blob/master/src/containers/JoinServerPrompt/index.tsx#L70
This will result in reverting your changes and forcing the nickname in the settings as new value.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/containers/JoinServerPrompt/index.tsx around line 70, where the reported effect is fired. Reproduce the issue by editing the nickname in the ingame browser and observe whether the change is reverted. Done means editing the nickname no longer forces a re-render that replaces the in-progress value.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100