Elasticsearch errors in API response
Open
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 755
- Forks
- 128
- PR merge metrics
- No merged PRs in 30d
Description
Deleting a task may return an error if the task was not (yet) indexed by the search engine, even if the task was successfully deleted.
Api_task.php:233
try {
$this->elasticsearch->delete('task', $task_id);
$this->elasticsearch->index('user', $this->user_id);
} catch (Exception $e) {
$additionalMsg = get_class() . '.' . __FUNCTION__ . ':' . $e->getMessage();
$this->returnError(105, $this->version, $this->openmlGeneralErrorCode, $additionalMsg);
return;
}
Is it intended behavior to return that 105 error?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at Api_task.php:233 and reproduce deleting a task before it is indexed by Elasticsearch. Trace how the caught exception becomes API error 105, then confirm the intended response behavior with the project maintainers. Done means the API no longer reports a misleading result, or the intended error behavior is explicitly confirmed and covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- elasticsearch, php
- Domain
- api, backend, search
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100