openlibhums / openlibhums/janeway
ModuleNotFoundError prevents new journal creation if any plugin does not have plugin_settings
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 238
- Forks
- 97
- Avg merge
- 9d 1h
- Merged PRs (30d)
- 8
Description
Bug
If a plugin does not have plugin_settings.py, it prevents the Janeway press manager from setting up new journals after they are created. The journal is created but has no IssueType and potentially is missing other items.
Solution
I believe this is because an ImportError is expected during plugin installation, but a ModuleNotFoundError is being raised. Changing this line to catch both types fixes the problem:
Versions
- Janeway r-1.8.x
- Python 3.11
To reproduce
- Install the
file_editorplugin - Navigate to the press manager / dashboard
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/core/logic.py around lines 907-928 and the journal setup flow in src/press/views.py around lines 165-184. Reproduce with the file_editor plugin on Python 3.11, then verify that creating a journal completes its setup, including IssueType, when a plugin lacks plugin_settings.py.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 78/100