openlibhums / openlibhums/janeway
news item date should be date published, not date drafted
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 238
- Forks
- 97
- Avg merge
- 9d 1h
- Merged PRs (30d)
- 8
Description
NewsItem.start_display is meant to control when a news item becomes
visible (e.g. embargoing a press release until an agreed date). Ordering
was fixed on master (2b1fca199 #5253 ) to respect it, but the date shown to readers on every news item still isn't — it shows posted (the creation/draft
timestamp) instead. For anything embargoed ahead of time, this makes the
item look like it was announced on the day it was drafted, not the day it
actually went live.
#5253 updated the ordering to ordering = ("-pinned", "sequence", "-start_display", "title") it did not update the date displayed.
Themes show date posted
They should show start display date.
Update Hourglass at the same time: https://github.com/openlibhums/hourglass/issues/479
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the theme templates that render news item dates and trace whether they use posted or start_display. Update the displayed value to the start display date, then verify embargoed news items show their publication date; apply the corresponding change in Hourglass issue #479.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- content, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100