openlibhums / openlibhums/janeway
Extra timeline.css in submission first and last step
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 238
- Forks
- 97
- Avg merge
- 9d 1h
- Merged PRs (30d)
- 8
Description
The templates submission/start.html and submission/submit_review.html include timeline.css:
{% block css %}
<link href="{% static 'admin/css/timeline.css' %}" rel="stylesheet">{% endblock %}
IIC, timeline.css is is @imported by static/admin/css/index.css, that is used by base.html, that is used in all submission templates. So the css block in the two aforementioned templates is probably useless.
Please note that this is not important nor urgent, but, since I've noticed, I thought I'd report it 🙂
I'm looking at r-v1.8.x
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect submission/start.html and submission/submit_review.html, then compare their css blocks with static/admin/css/index.css and the base.html inheritance they use. Remove the redundant timeline.css links and verify that both submission templates still receive the stylesheet through base.html.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css, html
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 78/100