openlibhums / openlibhums/janeway

Salutation Field should have a higher character cap

Open
#4,909 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

documentation new feature
Dominant language
Python
Stars
238
Forks
97
Avg merge
9d 1h
Merged PRs (30d)
8

Description

Is your feature request related to a problem? Please describe.
German salutations can get long when theres no additional "title" field for profiles. For example, a normal salutation in german could be "Herr Prof. Dr. rer. nat.", which is way beyond the char(10) cap.

Describe the solution you'd like
The field should allow more characters than 10, ideally something around 30 should be OK.

Describe alternatives you've considered
There could also be a seperate field for the "title", like "Prof. Dr.", so theres a difference between salutation and title. They both should be integrateable in the e-mail templates.

Additional context
There's also no mention about this cap in the janeway documentation (if I just happen to not find it, please do tell) and I think that should be added. We stumbled across this issue by testing the import feature.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by locating the salutation field and the import path, then check how the value is exposed to email templates. Done means the field accepts longer salutations, imports handle them correctly, and the character cap is documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend, documentation
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.