openlibhums / openlibhums/janeway

Janeway Repository: Links in PDF open in embedded PDF's window, not current tab/widow

Open
#4,819 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

dev-ready Priority high Repositories Size L
Dominant language
Python
Stars
238
Forks
97
Avg merge
9d 1h
Merged PRs (30d)
8

Description

Why
As a reader, I expect that links I click in the embedded PDF of a Janeway Repository object will go to a new window, rather than load in the embedded PDF viewer's window.

Janeway version
1.7.4

To Reproduce
Steps to reproduce the behavior:

  1. Go to a Janeway Repository item that has a PDF with links as the main text of the item, example: https://doi.org/10.31223/X5G150

  2. Click a link in the PDF
    Image

  3. Note that the link opens in the PDF viewer, and that there is no way to get back to the object PDF:
    Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with the linked Janeway Repository item and its embedded PDF, then inspect the PDF viewer entry point used for Repository objects. Done means links clicked inside the embedded PDF open outside the viewer while keeping the original object PDF accessible.

Written by the indexing model from the issue text.

Assessment

Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.