openlibhums / openlibhums/janeway

"Validation Error Shown Even When No Changes Are Made in Verify DOI Edit Form"

Open
#4,741 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug dev-ready Priority high Size S
Dominant language
Python
Stars
238
Forks
97
Avg merge
9d 1h
Merged PRs (30d)
8

Description

Describe the bug
In the "Verify DOI" section, when clicking "Edit" without making any changes and then clicking "Save," a validation error is still shown.

To Reproduce
Steps to reproduce the behavior:

Go to the "PrePublication" stage

Click on "Checklist"

In the "Verify DOI" section, click on "View DOI Data"

Click "Edit" on the popup

Without making any changes, click "Save"

See the validation error

Expected behavior
If no changes are made, the form should either not trigger a validation error or should be pre-filled with a valid format that passes validation.

Screenshots
https://prnt.sc/wKQgXvCTwAj3

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue through the PrePublication stage's Checklist, then open Verify DOI, View DOI Data, and the Edit form. Trace the form's validation behavior when Save is clicked without changes; done means an unchanged form no longer shows an invalid-format error or is pre-filled with a valid value.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.