openlibhums / openlibhums/janeway

Repository: "Edit metadata" shows all licenses, not licenses selected for repository

Open
#4,655 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug dev-ready Priority urgent Repositories Size XS
Dominant language
Python
Stars
239
Forks
97
Avg merge
9d 1h
Merged PRs (30d)
8

Description

Describe the bug
As a Repository Manager, I am sometimes asked by the submitting author to update a preprint's CC license because they are unable to do so themselves in the Metadata Correction/Update workflow. When I use the "Edit metadata" function to update licenses, however, the system displays all licenses in Janeway, and not only the licenses that have been selected for use in the Repository. As I do not have access to view all the licenses available in the Press or select the licenses in the Repository Wizard setup, this can be especially confusing for me.

Janeway version
Seen in 1.5.x and 1.b7.4.

To Reproduce
Steps to reproduce the behavior:

  1. In a Janeway Press with many different licenses, log in on a SuperUser/Admin account and confirm the selected licenses for the Repository:
    Image

  2. Log out and log back in on a Repository Manager account, then start a new submission; confirm that only the selected licenses are visible to a submitting author:
    Image

  3. Go to Repository Manager and select a published preprint, click "Edit metadata", then try to edit the license; note that all licenses in Press are visible:
    Image

Expected behavior
Only a SuperUser/Admin account would see all licenses in Janeway in the "Edit Metadata" functionality. Repository Managers should not see the other licenses available unless they are updating a preprint which has a license that is not currently supported (i.e. they would see that unsupported license, then only the other supported/selected licenses).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the Repository Manager workflow described in the issue, starting with Repository Manager and the “Edit metadata” function. Trace how the license choices are assembled and compare them with the licenses selected in the Repository setup. Done means Repository Managers see only supported selected licenses, plus any license already assigned to the preprint, while SuperUser/Admin users still see all licenses.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.