openlibhums / openlibhums/janeway

Repository: Manager w/o access to Press shouldn't see Press Manager link in Repository Manager navigation

Open
#4,647 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug dev-ready Priority urgent Repositories Size XS
Dominant language
Python
Stars
238
Forks
97
Avg merge
9d 1h
Merged PRs (30d)
8

Description

Describe the bug
When accessing the Repository Manager on an account that is assigned Repository Manager permissions but not Press Manager, Superuser, etc permissions, the "Press Manager" link is visible.

Janeway version
1.7.4

To Reproduce
Steps to reproduce the behavior:

  1. Log into a Janeway Repository with an account that only has Manager permissions for that Repository and not the Press.
  2. Click on the Repository Manager page.
  3. Note the "Press Manager" link at the top nav and click the link
    Image
  4. See error (expected): "Permission Denied"
    Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue from the Repository Manager page using an account with Repository Manager permission but no Press Manager access. Inspect the Repository Manager navigation entry for the Press Manager link and verify that it is hidden for this account while authorized users retain access and unauthorized direct access still shows Permission Denied.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
authorization, backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.