openlibhums / openlibhums/janeway

Double review file download link - one broken

Open
#4,594 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug Priority high
Dominant language
Python
Stars
238
Forks
97
Avg merge
9d 1h
Merged PRs (30d)
8

Description

Describe the bug
On review #21223 on Glossa, the author can see two file download links, only one is functional and the other returns an error. This was confusing for the author as they thought they were missing a file and thus contacted the editor who contacted support. Especially as there are two reviews (as is often the case), it confused the author into thinking there should have been two accessible file. (One review didn't have a file associated, just webform.)

Image

Janeway version
1.7

Additional context
See FD 9668

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the duplicate download links for review #21223 on Glossa and compare the review with and without an associated file. Trace how each link is generated and identify why the non-functional link appears; done means only the valid file link is shown and the broken link no longer returns an error.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.